-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pipeline) Migrate from trusted.ci.jenkins.io to infra.ci.jenkins.io #37
chore(pipeline) Migrate from trusted.ci.jenkins.io to infra.ci.jenkins.io #37
Conversation
1b71b00
to
882687c
Compare
(edit) nevermind: the error is related to the |
5180cef
to
0345bf3
Compare
OK, seems good to me. I need a careful review (what did I miss because for sure I missed something) + 24h to ensure that the reports are generated repeatly as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Some nitpicks, one blocking suggestion.
The indentation is all over the place, mixing spaces and tabs, will need some formatting.
@lemeurherve spaces fixed on Jenkinsfiles |
4e059b2
to
3353f5b
Compare
@dduportal WDYT about restoring the Dockerfile(s) so users can locally run these scripts without having to install their dependencies? |
They should use the image |
@lemeurherve README updated + stage name updated so the github checks are easier to catch. |
Closing the PR to avoid messing up with current trusted.ci. Will be reopen with fixes |
6115adb
to
ac9023f
Compare
Hello @zbynek @daniel-beck @NotMyFault @timja @lemeurherve I've reopen the PR with the following notable changes (after the issues which caused jenkins-infra/plugin-site#1150):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't access infra. to verify the integrity of the generate files, but that sounds reasonable.
Update:
|
I'd say go for it. |
Artifacts based comparison seems preferable. |
45931e2
to
fedc626
Compare
…s.io Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
736abec
to
1f3ab6c
Compare
Proceeding to merge + disabling former job in trusted.ci. |
This PR migrates the build from trusted.ci into infra.ci as per jenkins-infra/helpdesk#2789
ERROR: Can only call publishReports from within the trusted.ci environment
) - feat: allow publishing reports on infra.ci pipeline-library#348azure-reports-access-key
to the infra-report folder - feat(infra.ci) add the azure storage key required for publishing reports from infra-reports kubernetes-management#2181github-reports
on trusted.ci[edit (added after the 1s pass of review)]
A few notes:
jq
,az
CLI)